Mirror/GodMode9
1
0
Fork 1
mirror of https://github.com/d0k3/GodMode9.git synced 2025-06-26 13:42:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix / improve the path copy function

Browse Source 
This previously failed when copying dirs with a subdir depth > 7
This commit is contained in:
d0k3 2017-03-02 22:05:28 +01:00
parent 8535fcf163
commit 55e3da2e3c
2 changed files with 20 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
source/fatfs/ffconf.h
View File

@ -229,7 +229,7 @@
/ These options have no effect at read-only configuration (_FS_READONLY = 1). */ / These options have no effect at read-only configuration (_FS_READONLY = 1). */
#define _FS_LOCK 8 #define _FS_LOCK 32
/* The option _FS_LOCK switches file lock function to control duplicated file open /* The option _FS_LOCK switches file lock function to control duplicated file open
/ and illegal operation to open objects. This option must be 0 when _FS_READONLY / and illegal operation to open objects. This option must be 0 when _FS_READONLY
/ is 1. / is 1.

34
source/fs/fsutil.c
View File

@ -487,6 +487,10 @@ bool PathCopyVrtToFat(char* dest, char* orig, u32* flags) {
*(dname++) = '/'; *(dname++) = '/';
strncpy(dname, oname, 256 - (dname - dest)); strncpy(dname, oname, 256 - (dname - dest));
// path string (for output)
char deststr[36 + 1];
TruncateString(deststr, dest, 36, 8);
// open / check virtual file // open / check virtual file
if (!GetVirtualFile(&vfile, orig)) if (!GetVirtualFile(&vfile, orig))
return false; return false;
@ -499,10 +503,8 @@ bool PathCopyVrtToFat(char* dest, char* orig, u32* flags) {
} }
const char* optionstr[5] = const char* optionstr[5] =
{"Choose new name", "Overwrite file(s)", "Skip file(s)", "Overwrite all", "Skip all"}; {"Choose new name", "Overwrite file(s)", "Skip file(s)", "Overwrite all", "Skip all"};
char namestr[36 + 1];
TruncateString(namestr, dest, 36, 8);
u32 user_select = ShowSelectPrompt((*flags & ASK_ALL) ? 5 : 3, optionstr, u32 user_select = ShowSelectPrompt((*flags & ASK_ALL) ? 5 : 3, optionstr,
"Destination already exists:\n%s", namestr); "Destination already exists:\n%s", deststr);
if (user_select == 1) { if (user_select == 1) {
do { do {
if (!ShowStringPrompt(dname, 255 - (dname - dest), "Choose new destination name")) if (!ShowStringPrompt(dname, 255 - (dname - dest), "Choose new destination name"))
@ -539,7 +541,7 @@ bool PathCopyVrtToFat(char* dest, char* orig, u32* flags) {
// create the destination folder if it does not already exist // create the destination folder if it does not already exist
if (fa_opendir(&pdir, dest) != FR_OK) { if (fa_opendir(&pdir, dest) != FR_OK) {
if (f_mkdir(dest) != FR_OK) { if (f_mkdir(dest) != FR_OK) {
ShowPrompt(false, "Error: Overwriting file with dir"); ShowPrompt(false, "%s\nError: Overwriting file with dir", deststr);
return false; return false;
} }
} else f_closedir(&pdir); } else f_closedir(&pdir);
@ -563,12 +565,12 @@ bool PathCopyVrtToFat(char* dest, char* orig, u32* flags) {
u64 osize = vfile.size; u64 osize = vfile.size;
if (GetFreeSpace(dest) < osize) { if (GetFreeSpace(dest) < osize) {
ShowPrompt(false, "Error: File is too big for destination"); ShowPrompt(false, "%s\nError: File is too big for destination", deststr);
return false; return false;
} }
if (fx_open(&dfile, dest, FA_WRITE | FA_CREATE_ALWAYS) != FR_OK) { if (fx_open(&dfile, dest, FA_WRITE | FA_CREATE_ALWAYS) != FR_OK) {
ShowPrompt(false, "Error: Cannot create destination file"); ShowPrompt(false, "%s\nError: Cannot create destination file", deststr);
return false; return false;
} }
f_lseek(&dfile, 0); f_lseek(&dfile, 0);
@ -626,14 +628,18 @@ bool PathCopyWorker(char* dest, char* orig, u32* flags, bool move) {
*(dname++) = '/'; *(dname++) = '/';
strncpy(dname, oname, 256 - (dname - dest)); strncpy(dname, oname, 256 - (dname - dest));
// path string (for output)
char deststr[36 + 1];
TruncateString(deststr, dest, 36, 8);
// check if destination is part of or equal origin // check if destination is part of or equal origin
while (strncmp(dest, orig, 255) == 0) { while (strncmp(dest, orig, 255) == 0) {
if (!ShowStringPrompt(dname, 255 - (dname - dest), "Destination is equal to origin\nChoose another name?")) if (!ShowStringPrompt(dname, 255 - (dname - dest), "%s\nDestination is equal to origin\nChoose another name?", deststr))
return false; return false;
} }
if (strncmp(dest, orig, strnlen(orig, 255)) == 0) { if (strncmp(dest, orig, strnlen(orig, 255)) == 0) {
if ((dest[strnlen(orig, 255)] == '/') || (dest[strnlen(orig, 255)] == '\0')) { if ((dest[strnlen(orig, 255)] == '/') || (dest[strnlen(orig, 255)] == '\0')) {
ShowPrompt(false, "Error: Destination is part of origin"); ShowPrompt(false, "%s\nError: Destination is part of origin", deststr);
return false; return false;
} }
} }
@ -646,10 +652,8 @@ bool PathCopyWorker(char* dest, char* orig, u32* flags, bool move) {
} }
const char* optionstr[5] = const char* optionstr[5] =
{"Choose new name", "Overwrite file(s)", "Skip file(s)", "Overwrite all", "Skip all"}; {"Choose new name", "Overwrite file(s)", "Skip file(s)", "Overwrite all", "Skip all"};
char namestr[36 + 1];
TruncateString(namestr, dest, 36, 8);
u32 user_select = ShowSelectPrompt((*flags & ASK_ALL) ? 5 : 3, optionstr, u32 user_select = ShowSelectPrompt((*flags & ASK_ALL) ? 5 : 3, optionstr,
"Destination already exists:\n%s", namestr); "Destination already exists:\n%s", deststr);
if (user_select == 1) { if (user_select == 1) {
do { do {
if (!ShowStringPrompt(dname, 255 - (dname - dest), "Choose new destination name")) if (!ShowStringPrompt(dname, 255 - (dname - dest), "Choose new destination name"))
@ -687,7 +691,7 @@ bool PathCopyWorker(char* dest, char* orig, u32* flags, bool move) {
// create the destination folder if it does not already exist // create the destination folder if it does not already exist
if (fa_opendir(&pdir, dest) != FR_OK) { if (fa_opendir(&pdir, dest) != FR_OK) {
if (f_mkdir(dest) != FR_OK) { if (f_mkdir(dest) != FR_OK) {
ShowPrompt(false, "Error: Overwriting file with dir"); ShowPrompt(false, "%s\nError: Overwriting file with dir", deststr);
return false; return false;
} }
} else f_closedir(&pdir); } else f_closedir(&pdir);
@ -712,7 +716,7 @@ bool PathCopyWorker(char* dest, char* orig, u32* flags, bool move) {
if (fa_stat(dest, &fno) != FR_OK) if (fa_stat(dest, &fno) != FR_OK)
return false; return false;
if (fno.fattrib & AM_DIR) { if (fno.fattrib & AM_DIR) {
ShowPrompt(false, "Error: Overwriting dir with file"); ShowPrompt(false, "%s\nError: Overwriting dir with file", deststr);
return false; return false;
} }
if (f_unlink(dest) != FR_OK) if (f_unlink(dest) != FR_OK)
@ -731,13 +735,13 @@ bool PathCopyWorker(char* dest, char* orig, u32* flags, bool move) {
fsize = f_size(&ofile); fsize = f_size(&ofile);
if (GetFreeSpace(dest) < fsize) { if (GetFreeSpace(dest) < fsize) {
ShowPrompt(false, "Error: File is too big for destination"); ShowPrompt(false, "%s\nError: File is too big for destination", deststr);
fx_close(&ofile); fx_close(&ofile);
return false; return false;
} }
if (fx_open(&dfile, dest, FA_WRITE | FA_CREATE_ALWAYS) != FR_OK) { if (fx_open(&dfile, dest, FA_WRITE | FA_CREATE_ALWAYS) != FR_OK) {
ShowPrompt(false, "Error: Cannot create destination file"); ShowPrompt(false, "%s\nError: Cannot create destination file", deststr);
fx_close(&ofile); fx_close(&ofile);
return false; return false;
} }