Mirror/GodMode9
1
0
Fork 1
mirror of https://github.com/d0k3/GodMode9.git synced 2025-06-26 13:42:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix a potential buffer overflow

Browse Source 
thanks @windows-server-2003 !
This commit is contained in:
d0k3 2018-06-04 00:50:54 +02:00
parent 0cbcce5579
commit bdf635e39d
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
arm9/source/common/ui.c
View File

@ -345,9 +345,7 @@ void TruncateString(char* dest, const char* orig, int nsize, int tpos) {
int osize = strnlen(orig, 256); int osize = strnlen(orig, 256);
if (nsize < 0) { if (nsize < 0) {
return; return;
} else if (nsize <= 3) { } else if ((nsize <= 3) || (nsize >= osize)) {
snprintf(dest, nsize, "%s", orig);
} else if (nsize >= osize) {
snprintf(dest, nsize + 1, "%s", orig); snprintf(dest, nsize + 1, "%s", orig);
} else { } else {
if (tpos + 3 > nsize) tpos = nsize - 3; if (tpos + 3 > nsize) tpos = nsize - 3;

2
arm9/source/godmode.c
View File

@ -914,7 +914,7 @@ u32 FileAttrMenu(const char* file_path) {
return 1; return 1;
} }
char namestr[32]; char namestr[32 + 1];
char sizestr[32]; char sizestr[32];
TruncateString(namestr, fno.fname, 32, 8); TruncateString(namestr, fno.fname, 32, 8);
FormatNumber(sizestr, fno.fsize); FormatNumber(sizestr, fno.fsize);