Mirror/libstarlight
1
0
Fork 1
mirror of https://github.com/zetaPRIME/libstarlight.git synced 2025-06-26 05:32:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix replace blend mode on citra (which also fixes the clearing workaround)

Browse Source 
...also, actually disable depth testing instead of just thinking I did
This commit is contained in:
zetaPRIME 2017-05-03 09:10:02 -04:00
parent 5577b5a6a8
commit 2d93b903e4
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libstarlight/source/starlight/gfx/RenderCore.cpp
View File

@ -120,7 +120,7 @@ void RenderCore::Open() {
// set up mode defaults // set up mode defaults
C3D_AlphaBlend(GPU_BLEND_ADD, GPU_BLEND_ADD, GPU_ONE, GPU_ONE_MINUS_SRC_ALPHA, GPU_ONE, GPU_ONE_MINUS_SRC_ALPHA); // premult C3D_AlphaBlend(GPU_BLEND_ADD, GPU_BLEND_ADD, GPU_ONE, GPU_ONE_MINUS_SRC_ALPHA, GPU_ONE, GPU_ONE_MINUS_SRC_ALPHA); // premult
C3D_DepthTest(true, GPU_GEQUAL, GPU_WRITE_ALL); // hmm. C3D_DepthTest(false, GPU_GEQUAL, GPU_WRITE_ALL); // hmm.
C3D_CullFace(GPU_CULL_NONE); C3D_CullFace(GPU_CULL_NONE);
} }
@ -160,7 +160,7 @@ namespace {
break; break;
case BlendMode::Replace: case BlendMode::Replace:
C3D_AlphaBlend(GPU_BLEND_MAX, GPU_BLEND_MAX, GPU_ONE, GPU_ZERO, GPU_ONE, GPU_ZERO); // flat replace C3D_AlphaBlend(GPU_BLEND_ADD, GPU_BLEND_ADD, GPU_ONE, GPU_ZERO, GPU_ONE, GPU_ZERO); // flat replace
C3D_TexEnvOp(env, C3D_RGB, 0, 0, 0); C3D_TexEnvOp(env, C3D_RGB, 0, 0, 0);
C3D_TexEnvOp(env, C3D_Alpha, GPU_TEVOP_A_SRC_ALPHA, GPU_TEVOP_A_SRC_ALPHA, 0); C3D_TexEnvOp(env, C3D_Alpha, GPU_TEVOP_A_SRC_ALPHA, GPU_TEVOP_A_SRC_ALPHA, 0);
C3D_TexEnvFunc(env, C3D_RGB, GPU_REPLACE); C3D_TexEnvFunc(env, C3D_RGB, GPU_REPLACE);

3
libstarlight/todo.txt
View File

@ -4,7 +4,8 @@
roadmap to v0.5.1 { roadmap to v0.5.1 {
- clear bug workaround implemented - clear bug workaround implemented
^ maybe replace clearing with the workaround entirely? ^ maybe replace clearing with the workaround entirely?
try to figure out why the workaround doesn't work in citra - try to figure out why the workaround doesn't work in citra (it was a difference between openGL and PICA blend operations!)
https://github.com/citra-emu/citra/issues/2684
implement more blend modes { implement more blend modes {
- flat replace - flat replace
masking masking